Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bump github.com/showwin/speedtest-go from 1.6.6 to 1.6.7 #14250

Merged
merged 3 commits into from
Nov 10, 2023
Merged

chore(deps): Bump github.com/showwin/speedtest-go from 1.6.6 to 1.6.7 #14250

merged 3 commits into from
Nov 10, 2023
+12 −11

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 6, 2023

Bumps github.com/showwin/speedtest-go from 1.6.6 to 1.6.7.

Release notes

Sourced from github.com/showwin/speedtest-go's releases.

v1.6.7

What's Changed

Full Changelog: showwin/speedtest-go@v1.6.6...v1.6.7

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
chore(deps): Bump github.com/showwin/speedtest-go from 1.6.6 to 1.6.7
17292f0 
Bumps [github.com/showwin/speedtest-go](https://github.com/showwin/speedtest-go) from 1.6.6 to 1.6.7.
- [Release notes](https://github.com/showwin/speedtest-go/releases)
- [Changelog](https://github.com/showwin/speedtest-go/blob/master/.goreleaser.yml)
- [Commits](showwin/speedtest-go@v1.6.6...v1.6.7)

---
updated-dependencies:
- dependency-name: github.com/showwin/speedtest-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 6, 2023
@telegraf-tiger telegraf-tiger bot added the chore label Nov 6, 2023
@powersj
Copy link
Contributor

powersj commented Nov 6, 2023

@r3inbowari,

Looks like the recent update in showwin/speedtest-go#156 broke compatibility with the UserConfig struct:

# github.com/influxdata/telegraf/plugins/inputs/internet_speed
plugins/inputs/internet_speed/internet_speed.go:126:3: unknown field ICMP in struct literal of type speedtest.UserConfig
# github.com/influxdata/telegraf/plugins/inputs/internet_speed
vet: plugins/inputs/internet_speed/internet_speed.go:126:3: unknown field ICMP in struct literal of type speedtest.UserConfig

Was the Geteuid check also removed?

@r3inbowari
Copy link
Contributor

Remove ICMP flag and use PingMode: speedtest.HTTP instead.

@powersj
Copy link
Contributor

powersj commented Nov 6, 2023

use PingMode: speedtest.HTTP instead.

This is not what we were using before. I'll take a look at maintaining our current process tomorrow. Ideally breaking changes get more than a bug fix release ;)

@r3inbowari
Copy link
Contributor

Ideally breaking changes get more than a bug fix release ;)

sorry. I will be careful next.

@powersj powersj requested a review from srebhan November 7, 2023 19:26
@powersj
Copy link
Contributor

powersj commented Nov 7, 2023

@r3inbowari I've pushed a change, would you be willing to review? thanks!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 7, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Nov 8, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj and @r3inbowari for fixing the issue!

@srebhan srebhan merged commit d644ffd into master Nov 10, 2023
24 checks passed
@srebhan srebhan deleted the dependabot/go_modules/github.com/showwin/speedtest-go-1.6.7 branch November 10, 2023 11:27
@github-actions github-actions bot added this to the v1.28.4 milestone Nov 10, 2023
powersj pushed a commit that referenced this pull request Nov 13, 2023
@dependabot @powersj
chore(deps): Bump github.com/showwin/speedtest-go from 1.6.6 to 1.6.7 (…
37351b9 
…#14250)

Co-authored-by: Josh Powers <[email protected]>
Co-authored-by: r3inbowari <[email protected]>
(cherry picked from commit d644ffd)
@chenrui333 chenrui333 mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r3inbowari r3inbowari r3inbowari left review comments

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
chore dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.28.4
Development

Successfully merging this pull request may close these issues.
3 participants
@powersj @r3inbowari @srebhan